====== AIRS-3178 Add "Country of Origin" to Material Master Data ====== [[https://tasks.supplyon.de/browse/AIRS-3178|AIRS-3178]] [[https://doc.supplyon.de/pages/viewpage.action?pageId=72524708|Spec in Confluence]] [[https://git.seeburger.de/r/c/supplyon/airsupply/+/87636|Change 87636 im Gerrit]] ===== Tests ===== ==== All candidates ==== * **-** ASNAddressUtil.java ? * **x** default_xx.properties * **x** Material_Overview_Seller_Download.xls * **-** MaterialController.java * **-** MaterialCSVDownloadScreen.java (added column for supplier) * **-** MaterialDAOImpl.java (added column) * **-** MaterialDetailsActionScreen.java * **-** fillSellerModel() * **-** trimCountryValue() * **x** materialDetailsCfg.js.jsp * **x** MaterialDetailsPanel.js * **-** MaterialFilter.java ? * **-** MaterialModel.java ? (added field) * **-** MaterialXLSDownloadScreen.java (added column for supplier) * **-** MaterialXLSUploadScreen.java (added column for supplier) * **-** setCountryOfOriginOrThrow() * **-** isValidCountryCode() * **x** pom.xml * **x** SASWebKeys.java * **x** SuiModelMDMaterial.js.inc * **x** V19.0.0.4_001_airsupply.sql * **x** V19.0.0.4_001_airsupply.sql ==== Candidates ==== * **?** ASNAddressUtil.java (currently no tests existing) * **?** MaterialController.java (currently no tests existing) * **?** MaterialCSVDownloadScreen.java (currently no tests existing; added only one column for supplier) * **-** MaterialDAOImpl.java (added column) * **-** MaterialDetailsActionScreen.java * **-** fillSellerModel() * **-** trimCountryValue() * **-** MaterialFilter.java ? * **-** MaterialModel.java ? (added field) * **?** MaterialXLSDownloadScreen.java (currently no tests existing; added column for supplier) * **+** MaterialXLSUploadScreen.java (added column for supplier) * **+** setCountryOfOriginOrThrow() ===== Questions ===== * **-** Why 25 characters? (the same is on ASN) * **-** Is XML Import really _not_ affected? * **-** Add new field to MaterialModel.getDefaultJSONNamesVMI()?