====== DEV_LOND2PLUS-2353 DELFOR - Change of pickup and delivery date column(s) ======

https://tasks.supplyon.de/browse/DEV_LOND2PLUS-2353

https://git.seeburger.de/r/c/supplyon/scm-auto/+/117361
===== Subtasks =====

  * ...
  * [[https://tasks.supplyon.de/browse/DEV_LOND2PLUS-2557|DEV_LOND2PLUS-2557 Add column to DTM]] 
  * ...


===== Original =====

**User-Story:**

AS A DELFOR user (buyside as well as sellside) I WANT the pick-up date information to be visible in UI in case the DELFOR contains both, delivery and pick-up date. 

 

==== AS-IS Situation ====
Within the Delivery Instruction process a date (shared) column "Delivery Date" / "Pick-up Date" is existing. DELFOR D10A allows 3 possible ways to send the date:

a) Only delivery date is being sent.  (DTM+2)\\ 
b) Only Pick-up date is being sent. (DTM+10)\\ 
c) Both dates are being sent. (DTM+12)\\ 


Delivery Instruction:
  * case a) Delivery date is displayed in column "Delivery Date". (OK)
  * case b) Pick-up date is displayed in column "Pick-up Date".  (hint: column delivery date and pick-up date is actually 1 shared column) --> to be changed
  * case c) Delivery date is displayed in column "Delivery date". The Pick-up date is not being displayed. --> to be changed

==== TO-BE ====
An additional column "Pick-up Date" needs to be implemented within Delivery Instruction Schedule lines view to show the supplier for info only

  * New column not visible by default
  * New column can be activated as required in UI
  * New column is read-only (as it is a demand info)
  * Download possibility in DTM (XLS and CSV), not part of the default download profile; to be configurable
  * Download possibility as VDA ( a) show delivery date, b) show pickup date, c) show delivery date )
  * New Column to be part of print

After finishing this user story, 2 separate columns should be available in DELFOR  schedule lines:
  * Delivery Date
  * Pick-up Date

Behavior: 
  * a) Delivery Date contains value; Pick-up date remains empty.
  * b) Pickup Date contains value; Delivery Date remains empty.
  * c) Both date columns contain a value.

 

Values from Schedule response --> column "Confirmed Date" (https://tasks.supplyon.de/browse/DEV_LOND2PLUS-2354):

a) Keep behavior as implemented already: in case of matching dates, add confirmed date to existing schedule line. Else add new line.

  * supply date from schedule response = delivery date from delivery instruction schedule line.

b) Same behavior as in case a) but with pickup date instead of delivery date.

c) Confirmed Date is always the delivery date. Same logic, as in a) applies.

 

Comment: DKO - possible blue green issue when adding new columns - tbc by DKO 

===== TODO =====

  * **-** Add columns to deliveryschedule table
    * **-** cTableColumnId = 12868  -> seller
    * **-** cTableColumnId = 12869  -> buyer

<code sql>
-- Example:
BEGIN
    SUI_TABLE.updateOrCreateSuiColConfig('masterdata', '/js/cfg/masterdata/overviewCfg.js.jsp', FALSE, 'ROHS_COMPLIANCE', 120, TRUE, FALSE, FALSE, -1, NULL, 34, TRUE);

    SUI_TABLE.updateOrCreateSuiColConfig('masterdata', '/js/cfg/masterdata/overviewCfg.js.jsp', TRUE, 'ROHS_COMPLIANCE', 120, TRUE, FALSE, FALSE, -1, NULL, 32, TRUE);
END;
</code>


  * **-** Download possibility in DTM (XLS and CSV), not part of the default download profile; to be configurable
    * DTM profiles
      * DTMProfileActionScreen
      * @DTMField annotation in ''DeliveryForecastDelivery''
      * If necessary (but in this case it is not!), an ''INSERT INTO PROFILEFIELD'' should be made.
  * **-** Download possibility as VDA ( a) show delivery date, b) show pickup date, c) show delivery date )
  * **-** New Column to be part of print

  * **-** Full check

  * ...

===== Questions =====
  * **+** Should I add also pickupDateLatest column? -> No
  * **+** Should I add inserts for new column(s) to D:\dev\intellij_ws\scm-auto\scm-testing\src\main\resources\sqltestdata\scm\data\tSUI_TableConfig.sql ? -> No, the proper path is: D:\dev\intellij_ws\scm-auto\sql\src\main\resources\sql\scm\v24\24.0.0.5\V24.0.0.5_20201006091300_001__scm.sql (<version>_<timestamp>_<number>_ _scm.sql)
  * **-** New column is read-only (as it is a demand info)
    * what does it mean? where is it defined?
  * **-** The column should be on which place?
    * PDF
    * JSP
  * **-** How to solve the problem with using the same table profile for print as for JSP?
    * Create new profile?