User Tools

Site Tools


airs-3860

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
airs-3860 [2020/03/09 15:04] – [Unit Tests] kalaschnikowairs-3860 [2020/03/11 12:11] (current) – [AIRS-3860 GR: Avoid Received Qty > Requested Qty] kalaschnikow
Line 1: Line 1:
 +====== AIRS-3860 GR: Avoid Received Qty > Requested Qty ======
 +
 +[[https://tasks.supplyon.de/browse/AIRS-3860|(Jira) AIRS-3860 GR: Avoid Received Qty > Requested Qty]]\\ 
 +[[https://doc.supplyon.de/display/S10058/GR%3A+Avoid+Received+Qty+%3E+Requested+Qty|(Confluence) AIRS-3860 GR: Avoid Received Qty > Requested Qty]]\\ 
 +[[https://git.seeburger.de/r/c/supplyon/airsupply/+/98831|(Gerrit) AIRS-3860 GR: Avoid Received Qty > Requested Qty]]
 +===== TODO =====
 +Spec:
 +  * This check can be enabled / disabled on customer legal entity level (by SupplyOn administrator) with configuration of
 +    * Which POs? Options are "CALLUP"; "Other"
 +    * Only without UE reference? Options are "Yes";"No"
 +
 +This means:
 +  * **+** Add two columns to tOrganization_SCD
 +    * cPOTypesToRejectGROvrdlvry (VARCHAR containing semicolon separated list of PO types)
 +    * cRejectGROvrdlvryWithoutUEs (INTEGER containing boolean)
 +  * **+** Add two fields to Organization model
 +    * **+** Decide what is to do with invalid entries
 +  * **+** Add code to DAOImpl
 +    * **+** read
 +    * **x** <del>write</del> (not necessary)
 +  * **-** Implement validation of these two new flags in ''SMGoodsReceiptOverdeliveryValidatorSTA''
 +  * **-** Add columns to Agenda
 +  * **-** Documentation of two new columns (where?) 
 +
 +===== Unit Tests =====
 +
 +  * **+** OrderTypeTest
 +  * **-** SMGoodsReceiptOverdeliveryValidatorSTATest
 +    * **+** "global" flag (''validateOverdelivery_Overdelivery_Reject()'' / ''_DontReject()'')
 +      * **+** false
 +      * **+** true
 +    * **+** RejectGrOverdeliveryOnlyWithoutUes
 +      * **+** true
 +        * **+** with Ues -> Dont Reject
 +        * **+** without Ues -> Reject
 +      * **+** false
 +        * **+** with Ues -> Reject
 +        * **+** without Ues -> Reject
 +    * **+** orderTypesToRejectGrOverdelivery
 +      * **+** with both types configured
 +        * **+** positive
 +      * **+** with one type configured
 +        * **+** positive
 +        * **+** negative
 +      * **+** with no types configured
 +        * **+** positive
 +===== Misc =====
 +  * Example of "comma separated value": ''cPOAlertOnStatus''
 +  * Maybe the following statements can be useful for data migration (hopefully not):
 +<code sql>
 +UPDATE TORGANIZATION_SCD SET cPOTypesToRejectGROvrdlvry='CALLUP,OTHER' where CREJECTGROVERDELIVERY=1;
 +UPDATE TORGANIZATION_SCD SET cRejectGROvrdlvryWithoutUEs=1 where CREJECTGROVERDELIVERY=1;
 +</code>